[SR-1702] NSJSONSerialization.data(...) fatalErrors on bad input #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Its a pity that we loose the unit-test :-/ Is there anything we can do about it? |
glenna
force-pushed
the
fix/fatalerror_on_jsonserialization_bad_input
branch
from
3750b32 to
57062ee
Compare
|
@phausler can you take a look? also any guidance about the tests? |
|
Sadly we do not yet have a way to validate fatal errors in XCTest. Shy of perhaps launching a NSTask to spawn the test in a sub-process. Overall this looks like a matching behavior to the objc counterpart. |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
seems just the build timed out @ianpartridge |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR-1702 NSJSONSerialization.data(withJSONObject:options:) should fatalError on bad input not throw
-removed the
throwin the case of using a stream: in both cases in objc it is anNSInvalidArgumentException-removed the test checking for the
throwin the case of the stream (and, AFAIK, there's no good way to test for fatalErrors, but happy to be corrected on that fact)