NSRegularExpression: Make options: default to empty to match Darwin

[spevans]

Brings it into line with the signatures @ https://developer.apple.com/documentation/foundation/nsregularexpression

[ianpartridge]

This looks good to me.

NSMatchingOptions and NSMatchingFlags need lifting inside NSRegularExpression too (and to lose their NS prefix). Would you be willing to open another PR to fix those?

https://developer.apple.com/documentation/foundation/nsregularexpression.matchingoptions
https://developer.apple.com/documentation/foundation/nsregularexpression.matchingflags

[spevans]

Do you mean renaming struct NSMatchingOptions to struct MatchingOptions and moving it inside an extension NSRegularExpression? And the same for NSMatchingFlags? I can do a PR for that

Do we also completely drop the NSMatchingOptions and NSMatchingFlags?

[ianpartridge]

Yes that's right. The various APIs that use them will need updating too (including the ones you added default parameters too in this PR).

[ianpartridge]

@swift-ci please test

[ianpartridge]

Looks like CI bot isn't working - I'll try again in the morning.

[alblue]

@swift-ci please test

[spevans]

It looks like the Jenkins CI jobs for Foundation arent listed on the ci.swift.org servers anymore (In the pull request tab)

[ianpartridge]

@shahmishal the CI bot for Foundation doesn't seem to be working - can you advise?

[alblue]

There was a mail sent to https://lists.swift.org/pipermail/swift-users/Week-of-Mon-20170731/006034.html (and others):

— ci.swift.org is back online, but we’re still working on restoring pull request testing. We expect full functionality by tomorrow.

I suspect the Foundation jobs are part of this restoration process.

[shahmishal]

@swift-ci please test

[ianpartridge]

@swift-ci please test and merge

[spevans]

Looks like the builds that ended up testing on 8 threads all took too along and were aborted by timeout

[ianpartridge]

@swift-ci please test and merge