URLSessionTask conforms to ProgressReporting protocol, added new instance properties. #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// A cancelable object that refers to the lifetime | ||
| /// of processing a given request. | ||
| open class URLSessionTask : NSObject, NSCopying { | ||
|
|
||
| public var countOfBytesClientExpectsToRecieve: Int64 { NSUnimplemented() } |
There was a problem hiding this comment.
Typo, should be countOfBytesClientExpectsToReceive.
KyeMaloy97
force-pushed
the
URLSessionTaskUpdates
branch
from
29283b0 to
f2f4339
Compare
|
Though I'm not aware of any feasibility study done to check the implementability of the new properties, its good to stub them out for now. Thanks! |
|
@swift-ci please test and merge |
|
cc @saiHemak |
pushkarnk
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLSessionTasknow conforms toProgressReportingprotocol.Also added the 3 other, new instance properties to it too, namely
earliestBeginDate,countOfBytesClientExpectsToRecieveandcountOfBytesClientExpectsToSend.