Enable building TestFoundation for profiling in Xcode #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phausler
reviewed
Aug 16, 2017
Foundation/Data.swift
Outdated
| @@ -790,7 +790,7 @@ public final class _DataStorage { | |||
| } | |||
| } | |||
|
|
|||
| internal class _NSSwiftData : NSData { | |||
| public class _NSSwiftData : NSData { | |||
There was a problem hiding this comment.
this is quite unfortunate since Data.swift is shared tween swift-corelibs-foundation and the overlay
There was a problem hiding this comment.
Is there a possible #if we could wrap around it?
There was a problem hiding this comment.
DEPLOYMENT_RUNTIME_SWIFT is defined for swift-corelibs-foundation and is not for the overlay since it's runtime is objc.
There was a problem hiding this comment.
but if you #if guard it please provide a comment explaining why this is needed.
There was a problem hiding this comment.
If we mark this public then others will come to depend upon it, making us unable to improve it in the future.
Supposedly the 'testable' feature is what we need for this, but I don't know what the support for testable is like on Linux.
Foundation/NSSwiftRuntime.swift
Outdated
| return unsafeBitCast(__NSCFType.self, to:UnsafeRawPointer.self) | ||
| } | ||
|
|
||
| @_cdecl("__CFInitializeSwift") | ||
| internal func __CFInitializeSwift() { | ||
| public func __CFInitializeSwift() { |
There was a problem hiding this comment.
why is this needed? can you attach the errors from the instruments attach?
There was a problem hiding this comment.
The errors I get when building for profiling are:
Undefined symbols for architecture x86_64:
"___CFInitializeSwift", referenced from:
___CFInitialize in libCoreFoundation.a(CFRuntime.o)
"___CFSwiftGetBaseClass", referenced from:
___CFInitialize in libCoreFoundation.a(CFRuntime.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
There was a problem hiding this comment.
What is the workflow you use to get there?
There was a problem hiding this comment.
So I guessed and just selected the test bundle as the profile target for instruments -
the linker invocation is wrong btw I think... It probably is attempting to link the real CoreFoundation instead of the libCoreFoundation.a
There was a problem hiding this comment.
The link command is
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch x86_64 -dynamiclib -isysroot /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -L/Users/spse/Files/src/swift/swift-corelibs-foundation/DerivedData/Foundation/Build/Products/Release -F/Users/spse/Files/src/swift/swift-corelibs-foundation/DerivedData/Foundation/Build/Products/Release -filelist /Users/spse/Files/src/swift/swift-corelibs-foundation/DerivedData/Foundation/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation.LinkFileList -init ___CFInitialize -install_name @rpath/SwiftFoundation.framework/Versions/A/SwiftFoundation -Xlinker -rpath -Xlinker @executable_path/../Frameworks -Xlinker -rpath -Xlinker @loader_path/Frameworks -mmacosx-version-min=10.11 -Xlinker -object_path_lto -Xlinker /Users/spse/Files/src/swift/swift-corelibs-foundation/DerivedData/Foundation/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation_lto.o -fobjc-link-runtime -L/Users/spse/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2017-08-14-a.xctoolchain/usr/lib/swift/macosx -Xlinker -add_ast_path -Xlinker /Users/spse/Files/src/swift/swift-corelibs-foundation/DerivedData/Foundation/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation.swiftmodule -twolevel_namespace -Wl,-alias_list,CoreFoundation/Base.subproj/SymbolAliases -sectcreate __UNICODE __csbitmaps CoreFoundation/CharacterSets/CFCharacterSetBitmaps.bitmap -sectcreate __UNICODE __properties CoreFoundation/CharacterSets/CFUniCharPropertyDatabase.data -sectcreate __UNICODE __data CoreFoundation/CharacterSets/CFUnicodeData-L.mapping -segprot __UNICODE r r -lcurl.3 -lxml2 -lCoreFoundation -lz -licucore -single_module -compatibility_version 150 -current_version 1303 -Xlinker -dependency_info -Xlinker /Users/spse/Files/src/swift/swift-corelibs-foundation/DerivedData/Foundation/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation_dependency_info.dat -o /Users/spse/Files/src/swift/swift-corelibs-foundation/DerivedData/Foundation/Build/Products/Release/SwiftFoundation.framework/Versions/A/SwiftFoundation
There is a -lCoreFoundation in there, so I think you are correct, I will see if I can fix up the linker command.
There was a problem hiding this comment.
I tossed a -v -Wl,-v on the clang linker command and it seems to be the right CF
There was a problem hiding this comment.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang \
> -arch x86_64 \
> -dynamiclib \
> -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk \
> -L/Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Products/Release \
> -F/Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Products/Release \
> -filelist /Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation.LinkFileList \
> -init ___CFInitialize \
> -install_name @rpath/SwiftFoundation.framework/Versions/A/SwiftFoundation \
> -Xlinker -rpath -Xlinker @executable_path/../Frameworks \
> -Xlinker -rpath -Xlinker @loader_path/Frameworks \
> -mmacosx-version-min=10.11 \
> -Xlinker -object_path_lto -Xlinker /Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation_lto.o \
> -fobjc-link-runtime \
> -L/Library/Developer/Toolchains/swift-LOCAL-2017-08-15-a.xctoolchain/usr/lib/swift/macosx \
> -Xlinker -add_ast_path -Xlinker /Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation.swiftmodule \
> -twolevel_namespace \
> -Wl,-alias_list,CoreFoundation/Base.subproj/SymbolAliases \
> -sectcreate __UNICODE __csbitmaps CoreFoundation/CharacterSets/CFCharacterSetBitmaps.bitmap \
> -sectcreate __UNICODE __properties CoreFoundation/CharacterSets/CFUniCharPropertyDatabase.data \
> -sectcreate __UNICODE __data CoreFoundation/CharacterSets/CFUnicodeData-L.mapping \
> -segprot __UNICODE r r \
> -Wl,-all_load \
> -lcurl.3 \
> -lxml2 \
> -lCoreFoundation \
> -lz \
> -licucore \
> -single_module \
> -compatibility_version 150 \
> -current_version 1303 \
> -Xlinker -dependency_info -Xlinker /Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation_dependency_info.dat \
> -o /Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Products/Release/SwiftFoundation.framework/Versions/A/SwiftFoundation -v -Wl,-v
Apple LLVM version 9.0.0 (clang-900.0.37)
Target: x86_64-apple-darwin17.0.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld" -demangle -lto_library /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/libLTO.dylib -dynamic -dylib -dylib_compatibility_version 150 -dylib_current_version 1303 -arch x86_64 -dylib_install_name @rpath/SwiftFoundation.framework/Versions/A/SwiftFoundation -init ___CFInitialize -macosx_version_min 10.11.0 -single_module -sectcreate __UNICODE __csbitmaps CoreFoundation/CharacterSets/CFCharacterSetBitmaps.bitmap -sectcreate __UNICODE __properties CoreFoundation/CharacterSets/CFUniCharPropertyDatabase.data -sectcreate __UNICODE __data CoreFoundation/CharacterSets/CFUnicodeData-L.mapping -segprot __UNICODE r r -syslibroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -twolevel_namespace -o /Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Products/Release/SwiftFoundation.framework/Versions/A/SwiftFoundation -L/Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Products/Release -L/Library/Developer/Toolchains/swift-LOCAL-2017-08-15-a.xctoolchain/usr/lib/swift/macosx -filelist /Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation.LinkFileList -rpath @executable_path/../Frameworks -rpath @loader_path/Frameworks -object_path_lto /Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation_lto.o -add_ast_path /Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation.swiftmodule -alias_list CoreFoundation/Base.subproj/SymbolAliases -all_load -lcurl.3 -lxml2 -lCoreFoundation -lz -licucore -dependency_info /Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Intermediates.noindex/Foundation.build/Release/SwiftFoundation.build/Objects-normal/x86_64/SwiftFoundation_dependency_info.dat -v -framework Foundation -lobjc -lSystem /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.0.0/lib/darwin/libclang_rt.osx.a -F/Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Products/Release
@(#)PROGRAM:ld PROJECT:ld64-302.3
configured to support archs: armv6 armv7 armv7s arm64 i386 x86_64 x86_64h armv6m armv7k armv7m armv7em (tvOS)
Library search paths:
/Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Products/Release
/Library/Developer/Toolchains/swift-LOCAL-2017-08-15-a.xctoolchain/usr/lib/swift/macosx
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/lib
Framework search paths:
/Users/phausler/Library/Developer/Xcode/DerivedData/Foundation-gmfgumwkdqjdvbazoebxtjjmneiy/Build/Products/Release
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/
Undefined symbols for architecture x86_64:
"___CFInitializeSwift", referenced from:
___CFInitialize in libCoreFoundation.a(CFRuntime.o)
"___CFSwiftGetBaseClass", referenced from:
___CFInitialize in libCoreFoundation.a(CFRuntime.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
So the problem is likely the flag -fobjc-link-runtime
There was a problem hiding this comment.
So why would the debug build always use the correct one?
There was a problem hiding this comment.
However we set in the project scope variable (with no override) CLANG_LINK_OBJC_RUNTIME to NO
There was a problem hiding this comment.
This may be an Xcode bug? (very skeptical of claiming that without a very clear reduced case). I will investigate more and let you know.
spevans
force-pushed
the
pr_xcode_release
branch
from
8b52807 to
f6c0f2e
Compare
|
Updated with fixes from @phausler |
phausler
approved these changes
Aug 16, 2017
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables building the TestFoundation executable in Release mode so that it can be profiled in Instruments.
Some symbols have been changed to
publicas they need to be exported to CoreFoundation and used for ObjCBridging.To profile, the TestFoundation scheme needs to be edited and the 'Profile(Release)' scheme set to 'Ask on Launch' for the executable. The Xcode project has not been updated as Xcode adds the full path to the executable and the path it adds in
TestFoundation.xcschemeis an absolute path including my homedir so it would not be applicable to anyone else.