make TestHTTPServer choose the port automatically rather than guessing #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spevans
reviewed
Aug 22, 2017
TestFoundation/HTTPServer.swift
Outdated
| this is the same as nthos which is a C macro which isn't available from Swift :\. | ||
| */ | ||
| static func from(networkByteOrder input: UInt16) -> UInt16 { | ||
| var val: UInt16 = input |
There was a problem hiding this comment.
Isn't this just UInt16(bigEndian:) ?
pushkarnk
reviewed
Aug 23, 2017
TestFoundation/HTTPServer.swift
Outdated
| and little endian machines. | ||
| Cf. https://commandcenter.blogspot.co.uk/2012/04/byte-order-fallacy.html | ||
|
|
||
| this is the same as nthos which is a C macro which isn't available from Swift :\. |
There was a problem hiding this comment.
a small typo here? did you mean ntohs?
There was a problem hiding this comment.
thanks, removed as of @spevans comment
pushkarnk
approved these changes
Aug 23, 2017
|
@swift-ci please test |
|
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@pushkarnk @spevans I'm actually expect the tests to fail in |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
|
cc @saiHemak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the loop to find a free port is ugly, error-prone and makes the tests less robust
fixing this here