Make JSON pretty-printing consistent with Darwin. #1205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, pretty-printing JSON results in a space before the colon, e.g.:
{
"key" : 4
}
ianpartridge
suggested changes
Sep 8, 2017
| @@ -989,6 +989,7 @@ extension TestJSONSerialization { | |||
| ("test_serialize_dictionaryWithDecimal", test_serialize_dictionaryWithDecimal), | |||
| ("test_serializeDecimalNumberJSONObject", test_serializeDecimalNumberJSONObject), | |||
| ("test_serializeSortedKeys", test_serializeSortedKeys), | |||
| ("test_colonPrettyPrintingMatchesDarwin", test_colonPrettyPrintingMatchesDarwin), | |||
There was a problem hiding this comment.
Can you call this test_serializePrettyPrinted() please? In time it should be expanded to test more than just the colon positioning, plus it is not actually testing Darwin compatibility, rather a string which currently matches Darwin. In other words, if Darwin is changed this test will not automatically start failing.
|
@spevans I thought you already fixed this recently but it appears not? |
|
I was going to in my PR that fixed all of the numeric types but left it out in the end. |
|
@ianpartridge : Renamed. |
ianpartridge
approved these changes
Sep 9, 2017
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, pretty-printing JSON results in a space before the colon, e.g.:
Addresses SR-5570.