Skip to content

Fix TestFoundation Imports #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Sep 17, 2017

As part of getting the swift-corelibs-foundation tests running against the system Foundation and XCTest, some issues have shown up with module imports.

  • Fix Glibc and Darwin to only be imported on the appropriate OS.
  • Remove unneeded import CoreFoundation.

@spevans
Copy link
Contributor Author

spevans commented Sep 17, 2017

@swift-ci please test

@ianpartridge
Copy link
Contributor

@swift-ci please test and merge

@swift-ci swift-ci merged commit 0e784e9 into swiftlang:master Sep 18, 2017
@spevans spevans deleted the pr_fix_test_imports branch September 19, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants