[4.0] JSONSerialization: Add missing numeric types #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for Int8/Int16/Int32/Int64, UInt8/UInt16/UInt32/UInt64, Decimal and NSDecimalNumber. - Improve serializeInteger performance to avoid overall speed regression. - Move JSONSerialization tests into correct testfile and use Int64 to stop tests breaking on 32bit platforms. - Add tests for isValidJSONObject() to test the support of new types. - Add tests for Float, Double, Decimal and NSDecimalNumber. JSONSerialization: Update error message to match Darwin JSONSerialization PR review fixes
|
@swift-ci please test |
martinknabbe
added a commit
to martinknabbe/SwagGen
that referenced
this pull request
Dec 5, 2017
JSONSerialization can handle Int64 and Int32 since Swift 4. Conformance to JSONRawType makes them encodable and decodable with JSONEncodable and JSONDecodable. swiftlang/swift-corelibs-foundation#1255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1197 to 4.0 branch.