NSAttributedString: Align methods with Darwin. #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add struct NSAttributedStringKey and use for the attribute key instead of String.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
ianpartridge
suggested changes
Oct 24, 2017
Foundation/NSAttributedString.swift
Outdated
| open func attributes(at location: Int, effectiveRange range: NSRangePointer) -> [String : Any] { | ||
|
|
||
| /// Returns the attributes for the character at a given index. | ||
| open func attributes(at location: Int, effectiveRange range: NSRangePointer) -> [NSAttributedStringKey : Any] { |
There was a problem hiding this comment.
The NSRangePointer should be optional: https://developer.apple.com/documentation/foundation/nsattributedstring/1415682-attributes
Foundation/NSAttributedString.swift
Outdated
| CFRunArrayInsert(_attributeArray, range, attrs._cfObject) | ||
| var _attrs: [String: Any] = [:] | ||
| for (key, value) in attrs { | ||
| _attrs[key.rawValue] = value |
|
@swift-ci please test |
ianpartridge
approved these changes
Oct 24, 2017
|
@swift-ci please test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of String.