Implement equality for NSNull #129
Conversation
kaandedeoglu
changed the title
| let null_4: NSNull? = nil | ||
|
|
||
| XCTAssertEqual(null_1, null_2) | ||
| XCTAssertEqual(null_1, null_3) |
There was a problem hiding this comment.
The NSNull exposed from objc should also have the property of a singleton. So I would also expect that XCTAssertTrue(null_1 === null_2)
There was a problem hiding this comment.
yes but wouldn't that break our NSNull.swift implementation? Should I do a conditional assert?
There was a problem hiding this comment.
in this particular case it preserves the effective functioning behavior of the "singleton-ness" of NSNull without needing a factory pattern init method. I think it is in the spirit of the API to preserve this and add an overload of the === operator to satisfy the expectation that one construction of NSNull() is to be treated as exactly the same as another construction of NSNull()
…dation Conflicts: TestFoundation/main.swift
|
@phausler |
|
looks great! |
Implement equality for NSNull
Implemented the
isEqualmethod forNSNull, that always returnstruefor twoNSNullinstances - thus giving it singleton semantics. (too bad we don't have factory methods or can't return references from initializers)Added tests.