Start implementing NSPredicate #131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I accepted an earlier PR that started the Predicate implementation, so we should rebase this one on top of that if it's still adding more functionality.
|
|
Closing this, adds nothing new to the other PR. |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
[docs] Add documentation about writing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started implementing predicates. Currently the constant and block-based predicates are done.
Since the class-cluster approach from Objective-C is not possible in Swift I replaced it with an internal protocol PredicateEvaluator. Depending on the type of predicate (that is which initializer is used) a different implementation of PredicateEvaluator is chosen. (So basically the Pimpl idiom from C++)
If you guys agree with this I will finish implementing NSPredicate and NSExpression in that style.
One thing I don't know how to solve is implementing
predicateWithSubstitutionVariables. Since the return type isSelfit would have to useself.dynamicType.initwith a required initializer, but there is no suitable initializer. I'd appreciate any hints how to implement this without having to change the public API.