Skip to content

build: migrate to the new ELF registration scheme #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2017
Merged

build: migrate to the new ELF registration scheme #1330

merged 1 commit into from
Nov 30, 2017

Conversation

compnerd
Copy link
Member

The new ELF registration scheme uses linker tables and only requires a
single object to be added to the link.

@compnerd
build: migrate to the new ELF registration scheme
c6a964b 
The new ELF registration scheme uses linker tables and only requires a
single object to be added to the link.
@compnerd compnerd mentioned this pull request Nov 20, 2017
Merged
@alblue
Copy link
Contributor

alblue commented Nov 23, 2017

Does this require synchronous testing across all repositories with this change? Do you know when it's planned to land?

@compnerd
Copy link
Member Author

compnerd commented Nov 26, 2017 •
edited
Loading

@alblue yeah, it requires synchronous testing :-(. I was looking into a final failure with the ELF migration. There is a single failure in a single test case now (associated type reflection for a remote image which is not loaded but rather mapped into memory). It is part of the same ELF metadata loading change (swiftlang/swift#12758) for now at least.

@compnerd compnerd merged commit 67a5d39 into swiftlang:master Nov 30, 2017
@compnerd compnerd deleted the ELF-registration branch November 30, 2017 19:21
@compnerd
Copy link
Member Author

This was tested as part of swiftlang/swift#12758

aschwaighofer added a commit that referenced this pull request Dec 1, 2017
@aschwaighofer
[4.1] Revert "Merge pull request #1330 from compnerd/ELF-registration"
4cad7cf 
This reverts commit 67a5d39, reversing
changes made to e41c5e4.

I believe this is breaking linux bots and I believe this needs
synchronized changes in swift-4.1-branch of swift.

rdar://35780906
@aschwaighofer
Copy link
Contributor

Hi @compnerd this got auto merged to swift-4.1-branch of corelibs. And is breaking there (https://ci.swift.org/job/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/258/)

I have reverted it on that branch: https://github.com/apple/swift-corelibs-foundation/commits/swift-4.1-branch

Because I believe if we want it there we also need to port swiftlang/swift#12758 to swift's swift-4.1-branch.

shahmishal added a commit that referenced this pull request Dec 7, 2017
@shahmishal
Revert "[4.1] Revert "Merge pull request #1330 from compnerd/ELF-regi…
b048681 
…stration""

This reverts commit 4cad7cf.
shahmishal added a commit that referenced this pull request Dec 7, 2017
@shahmishal
Merge pull request #1356 from apple/re-revert-elf-registration
b841b60 
Revert "[4.1] Revert "Merge pull request #1330 from compnerd/ELF-regi…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compnerd @alblue @aschwaighofer