Determine the Timezone directory to use at runtime on macOS. #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The timezone directory changed on macOS 10.13 so get the os version at runtime and set the timezone directory dynamically. This allows the tests to be run on 10.12 and 10.13 - Added __InitTZStrings() for both Linux and macOS to work the same way as Windows.
|
@swift-ci please test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timezone directory changed on macOS 10.13 so get the os version
at runtime and set the timezone directory dynamically. This allows
the tests to be run on 10.12 and 10.13
Added __InitTZStrings() for both Linux and macOS to work the same
way as Windows.
Reapplication of #1126 / #1163 after revert in #1338