[gardening] Use optional binding #1358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
These look good to me. What do you think @phausler ? Do we need to update similar things elsewhere e.g. in overlays? |
ianpartridge
reviewed
Dec 7, 2017
TestFoundation/TestStream.swift
Outdated
| let testFile = createTestFile("testFile_in.txt", _contents: messageData) | ||
| if testFile != nil { | ||
| let url = URL(fileURLWithPath: testFile!) | ||
| if let testFile = createTestFile("testFile_in.txt", _contents: messageData) { |
There was a problem hiding this comment.
While these are all improvements, I think perhaps we could do better:
guard let testFile = createTestFile("testFile_in.txt", _contents: messageData) else {
XCTFail("Unable to create temp file")
return
}
...guard is great for reducing the indentation and putting failure code near the test.
|
Submitted swiftlang/swift#13314 for some overlays. |
|
yea, we should keep the overlays and swift-corelibs-foundation in sync. the change looks reasonable to me (however I didnt really get a chance to go over it in detail but it seems rather mechanical and isomorphic) |
parkera
approved these changes
Dec 7, 2017
|
@swift-ci test and merge |
|
@swift-ci Please test and merge |
1 similar comment
|
@swift-ci Please test and merge |
ikesyo
force-pushed
the
optional-binding
branch
from
682c6b1 to
a4fb766
Compare
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.