-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[NSMutableArray] replace objects in range docs/tests/impl #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NSMutableArray] replace objects in range docs/tests/impl #136
Conversation
@@ -1041,36 +1043,37 @@ | |||
EA66F65A1BF1976100136161 /* Tests */ = { | |||
isa = PBXGroup; | |||
children = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simply sorted the order here.
What you're seeing is the lack of implicit bridging from Int to NSNumber. Unfortunately this is expected behavior until we can get implicit bridging figured out when the ObjC runtime is not present. |
got it. that makes a lot of sense. Do I need to change anything about this pull then? |
/// Replaces the objects in the receiving array specified by one given range with the objects in another array specified by another range. | ||
/// - parameter range: The range of objects to be replaced in (or removed from) the receiving array. | ||
/// - parameter otherArray: The array of objects from which to select replacements for the objects in `range`. | ||
/// - parameter otherRnage: The range of objects be selected from `otherArray` as replacements for the objects in `range`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here in otherRnage
Other than the typo, looks good to me. |
257b3eb
to
b0c3612
Compare
fixed |
b0c3612
to
c70f7bc
Compare
It looks like there are at least three implementations of this method now: |
From the Contribution Guidelines:
|
My mistake. Dunno how I missed #125! ill be more careful next time |
[test] Update for TestLocation utf8/16 change
[pull] swiftwasm from main
I think I found a bug while writing these tests. Not sure what the process is for filing it, but I was getting a a complier error "Int does not conform to expected element type AnyObject" when doing
NSMutableArray(array: [1, 2, 3])
which seems...wrong.Tested on latests official xcode build from app store and it definitely works.
Will be happy to try and resolve that issue before this gets merged as the tests look a little verbose as a result of the bug.