Restore the .concurrent option for NSArray's enumerateObjects(…) #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods in NSArray. - These methods are implemented as (relevant NSIndexSet).enumerate(options: options…), so the fix goes in NSIndexSet. - Includes NSArray tests.
…'re supposed to see, not until we see one that isn't supposed to be seen (because it may arrive out of order vs others we want to mark as seen.)
|
@swift-ci please test. |
parkera
approved these changes
Dec 11, 2017
|
@swift-ci Please test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Let's try this again. The previous attempt had an issue in the test for enumerateObjects(at:options:using:) where it could've set the stop flag to true before all indexes corresponding to our expectation had been set to true, which could lead it to inconsistently failing.)
NSArray implements these methods as:
someIndexSet.enumerate(options: options) { block(self[$0]…) }, so the fix goes in NSIndexSet.Includes NSArray tests.