Skip to content

Moving TransferState out of http folder #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

saiHemak
Copy link
Contributor

@saiHemak saiHemak commented Dec 11, 2017

TransferState has 1-on-1 relationship with EasyHandle and is independent of protocol.Hence it has been moved out of the http folder.In the next PR, this code will be aligned under NativeProtocol instead of HTTPURLprotocol which can be used across different protocols.

@alblue , I understand that this PR alone will not make much sense as the code is still an extension of HTTPURLProtocol.To address #1355 ,I have raised PR for the movement of the file.The code under this PR will be renamed to _NativeProtocol in the next PR.

@pushkarnk
Copy link
Member

This is just a file movement intended for work coming up in a future PR.

@swift-ci please test and merge

@alblue
Copy link
Contributor

alblue commented Dec 11, 2017

@swift-ci please test and merge

1 similar comment
@pushkarnk
Copy link
Member

@swift-ci please test and merge

@pushkarnk
Copy link
Member

pushkarnk commented Dec 12, 2017

Build failure again. Looks like a CI problem.
@shahmishal We've been seeing this merger issue since yesterday. Can you please help us out? Thank you.

ERROR: Step ‘Github Pull Request Merger’ aborted due to exception: 
java.io.IOException: Server returned HTTP response code: 405 for URL: https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1369/merge
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1876)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1474)
	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:338)
	at org.kohsuke.github.Requester.parse(Requester.java:602)
Caused: java.io.IOException: Server returned HTTP response code: 405 for URL: https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1369/merge
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1926)
	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1921)
	at java.security.AccessController.doPrivileged(Native Method)
	at sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:1920)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1490)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1474)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:254)
	at org.kohsuke.github.Requester.parse(Requester.java:612)

@shahmishal
Copy link
Member

@pushkarnk Looking into it.

@shahmishal
Copy link
Member

@swift-ci please test and merge

@shahmishal
Copy link
Member

@pushkarnk It should be fixed now

@pushkarnk
Copy link
Member

Thanks @shahmishal ! I appreciate the prompt response :)

@saiHemak
Copy link
Contributor Author

Thank you @shahmishal

@swift-ci swift-ci merged commit a3898c1 into swiftlang:master Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants