Added JSON serialization mechanism #137

manavgabhawala · 2015-12-13T09:26:16Z

Adds initial code for (almost) RFC compliant JSON serialization mechanism to convert JSON (in the form of AnyObject) to NSData. Works with PrettyPrinted option too.

phausler · 2015-12-13T17:51:59Z

Foundation/NSJSONSerialization.swift

+        return str.dataUsingEncoding(NSUTF8StringEncoding)!
+    }
+
+    private class func JSONSerialize(object: AnyObject, newIndent: String, newLine: String, space: String, indentation: String = "") throws -> String


object needs to be of type Any not AnyObject since this will not work for value types.

parkera · 2015-12-13T18:00:55Z

I think we'll also need some unit tests added for this before we accept it.

manavgabhawala · 2015-12-14T00:27:09Z

@phausler fixed the AnyObject -> Any but I also added in code to handle NSDictionary and NSArray because otherwise these objects weren't being handled. Bridging between [AnyObject] and NSArray doesn't work in the current version and that needs to be fixed.
@parkera Added test cases to test serialization.
I ran the tests and it succeeded separately on Darwin but I wasn't able to build or run them on Linux.

phausler · 2015-12-16T15:22:24Z

There seem to be a few compile failures with this still

oundation/NSJSONSerialization.swift:210:45: warning: cast from 'NSArray' to unrelated type '[AnyObject]' always fails
            return try serializeArray(array as! [AnyObject], newIndent: newIndent, newLine: newLine, space: space, indentation: indentation)
                                      ~~~~~ ^   ~~~~~~~~~~~
Foundation/NSJSONSerialization.swift:215:45: warning: cast from 'NSDictionary' to unrelated type '[String : AnyObject]' always fails
            return try serializeObject(dict as! [String: AnyObject], newIndent: newIndent, newLine: newLine, space: space, indentation: indentation)
                                       ~~~~ ^   ~~~~~~~~~~~~~~~~~~~

and the tests also fail to compile

TestFoundation/TestNSJSONSerialization.swift:425:16: error: value of type 'NSString' has no member '_swiftObject'
        return string._swiftObject
               ^~~~~~ ~~~~~~~~~~~~
TestFoundation/TestNSJSONSerialization.swift:461:24: error: type of expression is ambiguous without more context
            let json = ["a": 4.0, "b": NSNull(), "c": "string", "d": false]
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
TestFoundation/TestNSJSONSerialization.swift:487:45: error: contextual type 'Any' (aka 'protocol<>') cannot be used with array literal
            XCTAssertEqual(try trySerialize([NSNull(), "hello", 1.0]), "[null,\"hello\",1.0]")
                                            ^~~~~~~~~~~~~~~~~~~~~~~~
TestFoundation/TestNSJSONSerialization.swift:497:25: error: type of expression is ambiguous without more context
            let first = ["a": 4.0, "b": NSNull(), "c": "string", "d": false]
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
TestFoundation/TestNSJSONSerialization.swift:498:26: error: type of expression is ambiguous without more context
            let second = [NSNull(), "hello", 1.0]
                         ^~~~~~~~~~~~~~~~~~~~~~~~
TestFoundation/TestNSJSONSerialization.swift:432:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize([String: Any]()), "{}")
                               ^
TestFoundation/TestNSJSONSerialization.swift:433:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize([String: NSNumber]()), "{}")
                               ^
TestFoundation/TestNSJSONSerialization.swift:434:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize([String: String]()), "{}")
                               ^
TestFoundation/TestNSJSONSerialization.swift:438:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize(json), "{}")
                               ^
TestFoundation/TestNSJSONSerialization.swift:440:9: warning: 'catch' block is unreachable because no errors are thrown in 'do' block
        catch {
        ^
TestFoundation/TestNSJSONSerialization.swift:449:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize(json), "{\"hello\":\"world\"}")
                               ^
TestFoundation/TestNSJSONSerialization.swift:452:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize(json), "{\"hello\":\"world\",\"swift\":\"is \\\\ \\\"awesome\\\"\"}")
                               ^
TestFoundation/TestNSJSONSerialization.swift:454:9: warning: 'catch' block is unreachable because no errors are thrown in 'do' block
        catch {
        ^
TestFoundation/TestNSJSONSerialization.swift:472:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize([String]()), "[]")
                               ^
TestFoundation/TestNSJSONSerialization.swift:473:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize([NSNumber]()), "[]")
                               ^
TestFoundation/TestNSJSONSerialization.swift:474:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize([Any]()), "[]")
                               ^
TestFoundation/TestNSJSONSerialization.swift:475:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize([AnyObject]()), "[]")
                               ^
TestFoundation/TestNSJSONSerialization.swift:477:9: warning: 'catch' block is unreachable because no errors are thrown in 'do' block
        catch {
        ^
TestFoundation/TestNSJSONSerialization.swift:485:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize(["hello", "swift⚡️"]), "[\"hello\",\"swift⚡️\"]")
TestFoundation/TestNSJSONSerialization.swift:486:32: error: call can throw, but it is executed in a non-throwing autoclosure
            XCTAssertEqual(try trySerialize([1.0, 3.3, 2.3]), "[1.0,3.3,2.3]")
                               ^

copumpkin · 2016-01-06T23:42:46Z

plutil could also use this, right?

phausler · 2016-01-07T17:56:41Z

plutil should have json support but it does not yet have that part of the implementation

copumpkin · 2016-01-07T18:14:56Z

@phausler yeah I understand. I just meant that when plutil grows support for JSON, it can use this code.

parkera · 2016-01-07T18:50:38Z

Yup, that's exactly what plutil on Darwin does.

czechboy0 · 2016-02-17T15:19:14Z

@manavgabhawala What's the status of this PR? I'm in need of this and would be happy to help out, however there haven't been any commits in two months.
Should I start anew or is this likely to get accepted?

manavgabhawala · 2016-02-18T02:15:27Z

@czechboy0 Pushed changes to make it work with the latest swift build snapshot.
@phausler Please review. Thanks

phausler · 2016-02-18T16:57:12Z

@swift-ci Please test

manavgabhawala · 2016-02-23T08:31:23Z

@phausler one test case was failing because the ordering of the keys of the dictionary was different on Linux builds. But I updated the test cases so that the ordering of keys doesn't impact the result of the test cases. Please test again.

phausler · 2016-02-29T17:34:39Z

@swift-ci Please test

…orts Remove `@testable import` and `-enable-testing`

phausler reviewed Dec 13, 2015
View reviewed changes

phausler self-assigned this Dec 13, 2015

phausler added the changes requested label Dec 13, 2015

Added JSON serialization mechanism

e49aa6c

manavgabhawala force-pushed the master branch from ce29ea1 to e49aa6c Compare March 31, 2016 02:02

manavgabhawala closed this Apr 3, 2016

atrick pushed a commit to atrick/swift-corelibs-foundation that referenced this pull request Jan 12, 2021

Merge pull request swiftlang#137 from benlangmuir/remove-testable-imp…

11dad82

…orts Remove `@testable import` and `-enable-testing`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added JSON serialization mechanism #137

Added JSON serialization mechanism #137

Uh oh!

manavgabhawala commented Dec 13, 2015

Uh oh!

phausler Dec 13, 2015

Uh oh!

parkera commented Dec 13, 2015

Uh oh!

manavgabhawala commented Dec 14, 2015

Uh oh!

phausler commented Dec 16, 2015

Uh oh!

copumpkin commented Jan 6, 2016

Uh oh!

phausler commented Jan 7, 2016

Uh oh!

copumpkin commented Jan 7, 2016

Uh oh!

parkera commented Jan 7, 2016

Uh oh!

czechboy0 commented Feb 17, 2016

Uh oh!

manavgabhawala commented Feb 18, 2016

Uh oh!

phausler commented Feb 18, 2016

Uh oh!

manavgabhawala commented Feb 23, 2016

Uh oh!

phausler commented Feb 29, 2016

Uh oh!

Uh oh!

Added JSON serialization mechanism #137

Added JSON serialization mechanism #137

Uh oh!

Conversation

manavgabhawala commented Dec 13, 2015

Uh oh!

phausler Dec 13, 2015

Choose a reason for hiding this comment

Uh oh!

parkera commented Dec 13, 2015

Uh oh!

manavgabhawala commented Dec 14, 2015

Uh oh!

phausler commented Dec 16, 2015

Uh oh!

copumpkin commented Jan 6, 2016

Uh oh!

phausler commented Jan 7, 2016

Uh oh!

copumpkin commented Jan 7, 2016

Uh oh!

parkera commented Jan 7, 2016

Uh oh!

czechboy0 commented Feb 17, 2016

Uh oh!

manavgabhawala commented Feb 18, 2016

Uh oh!

phausler commented Feb 18, 2016

Uh oh!

manavgabhawala commented Feb 23, 2016

Uh oh!

phausler commented Feb 29, 2016

Uh oh!

Uh oh!