Carving out common code out of HTTPMessage #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alblue Please review |
|
As you're adding Foundation/URLSession/Message.swift, does this need adding to the Xcode project too? |
saiHemak
force-pushed
the
message-split
branch
2 times, most recently
from
6e85ef4 to
e6d174c
Compare
saiHemak
force-pushed
the
message-split
branch
from
e6d174c to
9483cae
Compare
|
@ianpartridge I have added the XCode project file changes ..please review |
|
@swift-ci please test |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the common Header parsing code to Message.Swift which will be aligned under NativeProtocol Class in next PR.