Fix String.deletingPathExtension Inconsistency #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following code behaves differently on macOS and Linux: ```swift NSString(string: "..").deletingPathExtension ``` On Linux, the resulting value is `.` while on macOS, it's `..`. I think the latter make far more sense since `..` mean parent directly, treating the last dot as "extension" is a bit of a stretch. Plus, this logic existed on macOS longer (therefore has more existing users). So it make sense to align Linux Foundation's behavior to that of macOS.
dduan
force-pushed
the
fix-deletingPathExtension-inconsistency
branch
2 times, most recently
from
3f392e9 to
c171fed
Compare
|
Looks good to me, though maybe the variable names around this point — not just the one you're adding, the existing ones as well — could stand to be a little clearer :) |
|
Thanks! I can work on that. The other issue I'm seeing is unrelated tests (in the compiler) failing on CI. Do you have insights on that? |
|
Unfortunately, not as such. |
|
@millenomi I've renamed all local variables in the method. |
dduan
force-pushed
the
fix-deletingPathExtension-inconsistency
branch
from
c036da0 to
204f5d6
Compare
dduan
force-pushed
the
fix-deletingPathExtension-inconsistency
branch
from
204f5d6 to
32d542a
Compare
|
@swift-ci please test and merge |
kylef
pushed a commit
to kylef/PathKit
that referenced
this pull request
Dec 23, 2017
_Background_ A test for this API has been [failing, but only on macOS][0]. This is due to a implementation difference between the closed-source Foundation and its open-source counterpart. Recently, a [patch][1] has been made to the latter to fix this issue. The patch is [included][2] in the upcoming Swift 4.1 release. _Changes_ Add a condition to the test so it passes on both platforms for now. The expectation is that come Swift 4.1, this test will start failing on Linux and the condition will be removed then. [0]: https://travis-ci.org/kylef/PathKit/builds/289637066 [1]: swiftlang/swift-corelibs-foundation#1376 [2]: https://github.com/apple/swift-corelibs-foundation/commits/swift-4.1-branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code behaves differently on macOS and Linux:
On Linux, the resulting value is
.while on macOS, it's...I think the latter make far more sense since
..mean parent directory,treating the last dot as "extension" is a bit of a stretch. Plus, this
logic existed on macOS longer (therefore has more existing users). So it
make sense to align Linux Foundation's behavior to that of macOS.
JIRA: https://bugs.swift.org/browse/SR-6647