Move common protocol implementation to NativeProtocol #1377
Conversation
|
@alblue @pushkarnk @ianpartridge Please review |
pushkarnk
changed the title
|
LGTM |
|
@saiHemak Can you please refine the commit message to something like "Move common protocol implementation to NativeProtocol" |
pushkarnk
changed the title
pushkarnk
changed the title
pushkarnk
force-pushed
the
nativeprotocol-message
branch
2 times, most recently
from
db5148b to
56deee0
Compare
|
@swift-ci please test and merge |
saiHemak
force-pushed
the
nativeprotocol-message
branch
from
56deee0 to
a64972a
Compare
|
@swift-ci please test and merge |
|
I am unable to reproduce the build failure locally. |
|
@saiHemak I've kicked off a build again. If it fails may be we need to cleanup the workspace and re-trigger. Let's wait and watch |
| } | ||
|
|
||
| override func startLoading() { | ||
| NSRequiresConcreteImplementation() |
There was a problem hiding this comment.
Minor nit: In your next PR, could you make sure to fix the indentation here and in the method below? They should be indented by four spaces, not three.
There was a problem hiding this comment.
Sure thanks ! Actually, the concrete implementation of StartLoading will be moved here from HTTPURLProtocol. This is just a placeholder for now ..
Moving protocol agnostic implementation under NativeProtocol.
eg: Header parsing code is common to HTTP and FTP.In both cases the HEADERS are split based on CRLF characters.
HTTPURLProtocol.swift has some common implementation which will be moved to NativeProtocol.swift in the next PR.