Moving common implementation to NativeProtocol.swift #1389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiHemak
commented
Jan 5, 2018
| /// `internalState` tracks the state of transfers / waiting for callbacks. | ||
| /// The `state` tracks the overall state of the task (running vs. | ||
| /// completed). | ||
| fileprivate var internalState: _InternalState { |
There was a problem hiding this comment.
The property InternalState has been moved to NativeProtocol.The git diff is not showing properly and the code followed by the property is part of didReceve(headerData.
|
@alblue @pushkarnk please review |
|
@swift-ci please test |
|
@ianpartridge @pushkarnk @alblue , Can you please review |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #1355 , moving the common implementation to NativeProtocol.
Along with the movement I had to implement a
validateHeaderCompletemethod which basically checks whether the header is complete or not .However,in HTTP/0.9 , we received the body data before CURL tells us that the headers are complete and this behavior is specific to HTTP.Hence ,I have moved the common code to NativeProtocol and overridden the specific behavior in
HTTPURLProtocol.