UserDefaults: Implement volatile domains, argument domain #1403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Volatile domains. - UserDefaults.argumentDomain, a particular volatile domain, including arguments parsing. WIP: Requires testing.
|
@swift-ci Please test. |
|
:\ I may have to cut some tests, if I can't have TestFoudation do a |
|
@swift-ci Please test. |
|
Please rebase on master and resubmit |
|
This has been superseded by: #1408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements:
.volatileDomain(forName:)API and related calls.UserDefaults.argumentDomain.A note: since there is no language-supported bridging in Swift Foundation, we opt to accept and return value types (Array<>, Dictionary<,_>, Date, URL…) rather than reference types (NSArray, NSDictionary, NSDate, NSURL…). We internally convert to reference types them to a. check that you are only saving plist types and b. to support existing persistent domain API (since these objects go to CF and need to be reference types).