ExtraStringAPI: Sync with the overlay version #1406
Conversation
- The three functions are obsoleted in Swift 4.0. The bodies from the overlay wont compile due to use of internal symbols so replace with a fatalError() call which isnt used anyway. - Update callers of advanced(by:) to use index(offsetBy:).
|
@swift-ci Please test. |
| return String.UTF16View.Index(encodedOffset: encodedOffset.advanced(by: n)) | ||
| } | ||
| } | ||
| /// Construct from an integer offset. |
There was a problem hiding this comment.
Is there a way we can change this from an obsoleted to a renamed with instead, so that callers have the opportunity of a fixit to change? Alternatively, instead of just using "Unavailable" can we have a more descriptive message as to what they need to replace this with instead?
There was a problem hiding this comment.
For advanced(by:) would this suffice (I don't think a rename can be used in its place. ) ?
@available(swift, obsoleted: 4.0, message: "Use index(_,offsetBy:) instead.")
Im not sure what the alternatives are for the other 2 although I could remove them entirely since adding obsoleted functions does not really make sense anyway.
There was a problem hiding this comment.
We seem to be moving towards keeping them in for a release or two because then the compile error is clearer than 'can't find it'.
|
@swift-ci Please test and merge. |
The three functions are obsoleted in Swift 4.0. The bodies from
the overlay wont compile due to use of internal symbols so replace
with a fatalError() call which isnt used anyway.
Update callers of advanced(by:) to use index(offsetBy:).