Skip to content

Initial FreeBSD port of Foundation. #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2015
Merged

Initial FreeBSD port of Foundation. #141

merged 1 commit into from
Dec 16, 2015

Conversation

dcci
Copy link
Member

@dcci dcci commented Dec 14, 2015

Now that we got a working swiftc on FreeBSD, I started porting foundation (lots of tests failing because there's no support for that). There's still a lot to do, but this is a starting point.

bool OSAtomicCompareAndSwap32Barrier( int32_t oldValue, int32_t newValue, volatile int32_t *theValue );

void OSMemoryBarrier();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does FreeBSD have malloc_size? I was under the impression that it was similar to linux in that it defined malloc_usable_size instead.

@phausler
Copy link
Contributor

neat! overall this looks pretty decent of an initial #ifdef pass. What is the testing plan for this? I don't think there are any CI servers setup for this target.

@dcci
Copy link
Member Author

dcci commented Dec 14, 2015

After I get this working (there are still some build failures), I'll try running the test and try to set up a buildbot for this (but I think we're still away from it).
More patches/pull request will follow in the next days/weeks, I'd just like to merge small patches rather than carrying a big patch around (which will be hard to review, as well). Please let me know if you're fine with this.

@parkera
Copy link
Contributor

parkera commented Dec 14, 2015

In general we are happy to take portability diffs. This one will take me a bit to review but I have no problem merging it in. The only caveat is as @phausler mentioned - we may in the future take PRs or make changes ourselves which cause this port to fail to build or work correctly, since we are not testing it directly ourselves.

@parkera parkera self-assigned this Dec 14, 2015
@dcci
Copy link
Member Author

dcci commented Dec 14, 2015

I see, thanks. That's why I'm trying to upstream the bits ASAP so once I'm done with the porting I can setup a buildbot myself to catch failures. But at this point, I'm fine with submitting patches once I discovered some changes broke FreeBSD support, if you're fine with that.

parkera added a commit that referenced this pull request Dec 16, 2015
Initial FreeBSD port of Foundation.
@parkera parkera merged commit 387b11f into swiftlang:master Dec 16, 2015
@parkera
Copy link
Contributor

parkera commented Dec 16, 2015

Looks good to me.

atrick pushed a commit to atrick/swift-corelibs-foundation that referenced this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants