Fixed documentation on Calendar.compare() #1417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but can you squash these into a single commit and rebase onto master, instead of having the merge node? |
|
Sure, though, I think squashing and rebasing will require another PR. Let me try that and open a new one up. I'll keep this one open until then. |
|
Do we have the same error in the Swift overlay version? |
|
Going to close this PR in favor of a new one that has everything merged-up properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
comparemethod onCalendarsaidorderedAscendingtwice, when it meant to sayorderedAscendingandorderedDescending.