Update Status to reflect HTTPCookieStorage implementation status #1419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @AndrewSB Can you please resolve the conflicts so that we can merge this one? Thanks! |
|
There's one method that's still |
I'm not sure why these weren't updated in previous commits.
|
@pushkarnk rebased 👍 but it looks like #1422 has implemented the right thing in the interim. I'm sorry about not doing this sooner, I was having issues with my GitHub notifications, and it looked like I missed this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why these weren't updated in previous commits. Maybe I've misunderstood something. There appear to be a substantial number of tests, and a pretty complete looking implementation.