-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement NSMeasurement #1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Dante-Broggi
wants to merge
19
commits into
swiftlang:master
from
Dante-Broggi:implement-NSMeasurement
Closed
Implement NSMeasurement #1425
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3a135ea
Implement `adding(_:)` and `subtracting(_:)`
Dante-Broggi 5346f25
Implement `encode(_:)` and `init(coder:)`
Dante-Broggi da6abf6
Implement `canBeConverted(to:)` and `converting(to:)`
Dante-Broggi 04de52e
These don't return `NSMeasurement`
Dante-Broggi 902e1a9
I think `NSMeasurement` is immutable
Dante-Broggi ccfeece
Update `Status.md`
Dante-Broggi fa8fe19
Review - `"NS.dblval"` to `"NS.value"` and indentation
Dante-Broggi 2f4e5a1
`NSMeasurement` test case stub
Dante-Broggi fff371d
add `TestNSMeasurement.swift` to XCode
Dante-Broggi 8deb185
add `TestNSMeasurement` to `main.swift` test case list
Dante-Broggi f34df89
Add Tests, and fix other `"NS.dblval"`
Dante-Broggi 0b2f8d5
Fix some dumb mistakes and update `Status.md` for tests
Dante-Broggi a6a7651
Fix everything but `canBeConverted(to:)` and `#if` that out
Dante-Broggi 1e50a23
I suppose this should actually work.
Dante-Broggi 2f195f0
More minor reviewed typos
Dante-Broggi 6161d7b
Should have been more through
Dante-Broggi e9986ee
these particular values are unnessasary
Dante-Broggi 0f084a8
guard else errors need to use the origional errors
Dante-Broggi b4bc5a5
Clean up the dumb (spelling) mistakes
Dante-Broggi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NS.value