[4.2] [test] Drop stdlib-redundant tests #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasPrefix/hasSuffix is now available universally from the standard library (it used to be Darwin only). As such, these tests are redundant with the tests in the standard library (indeed they are literally copy-pasted from the stdlib). As test methodology changes, maintaining these across projects and platforms is troublesome.
|
@swift-ci please test |
|
@shahmishal @aschwaighofer this might be needed to unbreak CI Linux. Hoping to get a LGTM from @parker, but worse case we merge to unbreak CI, he can revert, and I’ll have to bring 🍻🍺 to apologize |
|
Merged to unblock CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.2 cherrypick of #1492