FileManager: Implement mountedVolumeURLs(includingResourceValuesForKeys:options:) #1496
Conversation
…ys:options:) - propertyKeys and options arent fully implemented. - Only works on Linux and macOS.
|
@swift-ci please test |
|
Neat |
|
cc @kperryua |
Foundation/FileManager.swift
Outdated
| urls.append(URL(fileURLWithPath: mountPoint[1], isDirectory: true)) | ||
| } | ||
| } | ||
| #elseif os(macOS) |
There was a problem hiding this comment.
Can you use canImport(Darwin) here instead? I'm ok with os(Linux) for the above because /proc/mounts is explicitly a Linux feature, but I'd rather not tie one Darwin API to a specific OS.
There was a problem hiding this comment.
I'm also half-thinking whether we also need to start using:
#else
#error("Requires a platform-specific implementation")
#endifnow that we do have #error.
- Add #error for non Linux/Darwin implementations, to be filled in later.
|
@swift-ci please test |
|
@millenomi I added both of those changes although the |
|
@swift-ci please test |
|
@spevans I think I want to push standardizing on canImport(Darwin) in the rest of corelibs-foundation, too. (i.e.: if it's a Darwin-based OS, we should ask if Darwin API are available, not which particular flavor of OS it is.) |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
propertyKeys and options arent fully implemented.
Only works on Linux and macOS.