Fixes a shadowed variable in the system time zone initializer. #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, hmm perhaps we should enable error on shadowing |
phausler
added a commit
that referenced
this pull request
Dec 16, 2015
Fixes a shadowed variable in the system time zone initializer.
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Add a `BuildSystemDelegate` which supports notifications for build settings changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shadowed variable that's being removed in this PR causes the name to fall out of scope as soon as it exits the "if (0 < ret)" block, and the outermost "name" field is left null. This causes the systemTimeZone to always report as GMT.
I'm not sure if the mechanism I'm using to test this is the best way to go. Calling into the C time functions seems like a hack, and something that might get broken by subtle changes to system configurations. It works on both my Mac and Linux installs, and it correctly gives an error when the change to CFTimeZone.c is removed.