Replace XCTAssertNotNil with enhanced tests on TestDate and TestTimer #1523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
reviewed
Apr 18, 2018
TestFoundation/TestDate.swift
Outdated
| } | ||
|
|
||
| func test_descriptionWithLocale() { | ||
| let d = NSDate(timeIntervalSince1970: 0) | ||
| XCTAssertEqual(d.description(with: nil), "1970-01-01 00:00:00 +0000") | ||
| XCTAssertNotNil(d.description(with: Locale(identifier: "ja_JP"))) | ||
| XCTAssertEqual(d.description(with: Locale(identifier: "en_US")), "Thursday, January 1, 1970 at 12:00:00 AM Greenwich Mean Time") |
There was a problem hiding this comment.
We explicitly did not want to test the exact string output here because it can change from time to time due to formatting differences.
There was a problem hiding this comment.
Maybe XCTAssert(d.description(with: Locale(identifier: "ja_JP")) != "") then? Or Just keep the old code?
There was a problem hiding this comment.
Or perhaps we could use en_US_POSIX locale as it should not change it's formatting.
There was a problem hiding this comment.
I'm fine with checking that isEmpty is false
otaviolima
force-pushed
the
enhance-timer-date-tests
branch
from
9db658a to
ca5f395
Compare
parkera
approved these changes
Apr 19, 2018
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1516 but in cases where simply removing the
XCTAssertNotNilwould not bring any benefit or even harm the test suite.