Skip to content

Fix IndexSet.contains(integersIn indexSet:) #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

zayass
Copy link
Contributor

@zayass zayass commented Apr 18, 2018

Current version not even use an input parameter
Just comparing self with itself

@spevans
Copy link
Contributor

spevans commented Apr 18, 2018

@swift-ci please test

Copy link
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes.

@zayass zayass force-pushed the fix/indexset-contains-another branch from 2aefa2b to 713087f Compare April 19, 2018 11:55
@zayass
Copy link
Contributor Author

zayass commented Apr 19, 2018

Whoops wrong test
Fixed
@spevans @parkera could you retest?

@spevans
Copy link
Contributor

spevans commented Apr 19, 2018

@swift-ci please test

1 similar comment
@alblue
Copy link
Contributor

alblue commented Apr 19, 2018

@swift-ci please test

@zayass
Copy link
Contributor Author

zayass commented Apr 19, 2018

@parkera Is it ok to merge?

@parkera
Copy link
Contributor

parkera commented Apr 19, 2018

Yup

@millenomi millenomi merged commit 95905cf into swiftlang:master Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants