[4.2] Use withUnsafeMutableBufferPointer in NSData test. #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that: - We produce a well scoped stable pointer for the duration of the use. - We aren't attempting to do an implicit conversion from an array to pointer in an argument position which is an autoclosure result, which is now disallowed in swiftlang/swift#16623. (cherry picked from commit b1a9c73)
|
@swift-ci Please test |
parkera
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that:
We produce a well scoped stable pointer for the duration of the use.
We aren't attempting to do an implicit conversion from an array to
pointer in an argument position which is an autoclosure result,
which is now disallowed in
Disallow some implicit pointer conversions in autoclosures. swift#16623.
(cherry picked from commit b1a9c73)