Fix URLRequest copying #1554
Merged
Fix URLRequest copying #1554
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
approved these changes
May 18, 2018
There was a problem hiding this comment.
Looks good to me. @ianpartridge anyone else to take a look?
|
@pushkarnk can you take a look please? |
|
@swift-ci please test |
|
@parkera @ianpartridge @pushkarnk |
|
I'm hoping @pushkarnk can take a look here; I'll merge unless they have an objection. |
|
@swift-ci test and merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of fields not copied
It works very bad when
Content-Lengthset buthttpBodyloosed after COW