Process: Deprecate old methods and properties, implement run() #1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mark launchPath and currentDirectoryPath as deprecated, replace with executableURL and currentDirectoryURL. - Implement run() and Process.run(_:arguments:terminationHandler:) and mark launch() and Process.launchedProcess(path:arguments:) as deprecated. - Update DarwinCompatibility Tests to 10.13 to use run().
|
@swift-ci please test |
|
@swift-ci please test |
millenomi
reviewed
May 21, 2018
Foundation/Process.swift
Outdated
| self.launchPath = newValue?.path | ||
| } | ||
|
|
||
| @available(*, deprecated: 4, renamed: "executableURL") |
There was a problem hiding this comment.
While this is allowed, I don't think the semantics for this are well-defined. (The '4' in the deprecated: portion is meant to be the version of the platform specified just after @available(, but in this case there's none.)
The semantically appropriate thing to do here, I think, is just to mark it:
@available(*, deprecated, renamed:…)There was a problem hiding this comment.
Unless it is undocumented that the Swift version is used even if the tag is not @available(swift, …)
There was a problem hiding this comment.
I wasn't sure if a version number was required, its fixed now.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark launchPath and currentDirectoryPath as deprecated,
replace with executableURL and currentDirectoryURL.
Implement run() and Process.run(_:arguments:terminationHandler:)
and mark launch() and Process.launchedProcess(path:arguments:) as
deprecated.
Update DarwinCompatibility Tests to 10.13 to use run().