Avoid runtime crashes by removing undefined behavior. #1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
reviewed
May 23, 2018
| @@ -628,6 +628,7 @@ static void *__CFTSDGetSpecific() { | |||
| #if DEPLOYMENT_TARGET_MACOSX || DEPLOYMENT_TARGET_EMBEDDED || DEPLOYMENT_TARGET_EMBEDDED_MINI | |||
| return pthread_getspecific(__CFTSDIndexKey); | |||
| #elif DEPLOYMENT_TARGET_LINUX | |||
| __CFTSDInitialize(); | |||
There was a problem hiding this comment.
I think this actually belongs here:
where we can probably just remove the requirement for DEPLOYMENT_RUNTIME_SWIFT and make it DEPLOYMENT_TARGET_LINUX.
There was a problem hiding this comment.
It took me bit to validate, but this works and I agree its best suited. I just updated the pull request, please take a look.
|
I think you have the commits for your other PR merged into this one. Can you separate them? |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From pthread docs:
"The effect of calling pthread_getspecific() or pthread_setspecific() with a key value not obtained from pthread_key_create() or after key has been deleted with pthread_key_delete() is undefined."
On some Linux flavors this results in getspecific returning uninitialized pointer with results in runtime crashes after dereferencing invalid memory.
Also NULL format for fprintf is invalid and results on crashes when calling CFShow.