Skip to content

replace for-loop based initialization #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

rauhul
Copy link
Member

@rauhul rauhul commented Jun 9, 2018

replace structures like:

for i in 0..<len {
    buf.advanced(by: i).initialize(to: 0)
}

with:

buf.initialize(repeating: 0, count: len)

should bring small performance improvements

@pushkarnk
Copy link
Member

@swift-ci please test

@millenomi
Copy link
Contributor

@swift-ci please test and merge

@swift-ci swift-ci merged commit 77a8e7b into swiftlang:master Jun 11, 2018
@rauhul rauhul deleted the pointer_initialization_update branch June 12, 2018 02:14
@rudkx
Copy link
Contributor

rudkx commented Jun 13, 2018

It looks like this commit might have broken the Ubuntu 18.04 test runs: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-18_04/329/console

@millenomi
Copy link
Contributor

@rudkx It is not clear to me that it has — the log you linked now 404s, and while I see that the build is broken, it is broken in URLSession tests, not NSURL creation. What are you seeing?

@rudkx
Copy link
Contributor

rudkx commented Jun 13, 2018

@millenomi I believe it was the same issue as the latest build:

 Fatal error: Unexpectedly found nil while unwrapping an Optional value: file TestFoundation/TestURLSession.swift, line 283

I may have jumped the gun assuming it was related to this commit, but I believe when I looked at the log earlier there were only two commits in the first build that broke, and the other seemed completely unrelated.

@shahmishal mentioned a little while ago that he is working on getting this bot blue, so perhaps it's completely unrelated to source changes and something about the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants