Skip to content

Fix open let properties #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2018
Merged

Fix open let properties #1595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc37b12
implementation
rauhul Jun 12, 2018
e75106e
replace public let with open private(set) var
rauhul Jun 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Foundation/NSURL.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,8 +955,8 @@ open class NSURLQueryItem : NSObject, NSSecureCoding, NSCopying {
&& other.value == self.value)
}

open let name: String
open let value: String?
open private(set) var name: String
open private(set) var value: String?
}

open class NSURLComponents: NSObject, NSCopying {
Expand Down
4 changes: 2 additions & 2 deletions Foundation/URLSession/URLSession.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,9 @@ open class URLSession : NSObject {
let _ = URLSession.registerProtocols
}

open let delegateQueue: OperationQueue
open private(set) var delegateQueue: OperationQueue
open var delegate: URLSessionDelegate?
open let configuration: URLSessionConfiguration
open private(set) var configuration: URLSessionConfiguration

/*
* The sessionDescription property is available for the developer to
Expand Down
4 changes: 2 additions & 2 deletions Foundation/URLSession/URLSessionTask.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ open class URLSessionTask : NSObject, NSCopying {
}

/// An identifier for this task, assigned by and unique to the owning session
open let taskIdentifier: Int
open private(set) var taskIdentifier: Int

/// May be nil if this is a stream task
/*@NSCopying*/ open let originalRequest: URLRequest?
/*@NSCopying*/ open private(set) var originalRequest: URLRequest?

/// May differ from originalRequest due to http server redirection
/*@NSCopying*/ open internal(set) var currentRequest: URLRequest? {
Expand Down