[Attempt 2] Implement FileManager.url{s,}(for:…) and NSSearchPathForDirectoriesInDomains. #1597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectoriesInDomains. Implement urls(for:…) as the primitive directory method: - In Darwin, match paths with the Objective-C implementation wherever possible. - On platforms that use FHS/XDG, implement reading user-dirs.* files to determine XDG directories; Implement url(for:in:…) and NSSearchPathForDirectoriesInDomains() in terms of urls(for:…).
…able. Additionally: allow building in Release correctly during development on Darwin.
|
@swift-ci please test |
|
This fixes the issues that caused the revert at #1596. |
|
I have locally tested this built in Debug and Release on Darwin. |
|
It looks like this still isn't making it past the CI builders. https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/4421/ Perhaps a difference in your configuration vs. the builders? I'll need to revert ASAP as this will hold other PR testing. |
|
It's passing PR testing, so it could also be an an incremental vs. clean build issue. |
This was referenced Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-proposes the patch at #1456 — see there for discussion.
Unlike that patch, this one changes the test setup and build so that
NS_FOUNDATION_ALLOWS_TESTABLE_IMPORTis defined iif the build product can be used in a@testable importexpression, and conditionalizes white-box tests to the presence of that flag. That flag is never available ifDEPLOYMENT_RUNTIME_OBJC, since macOS's Foundation will never be usable with@testable import.