Skip to content

closure: port use of dlsym to Windows #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Conversation

compnerd
Copy link
Member

This adjusts the initialization path to ensure that the lookup for
_Block_destructInstance is portable to Windows.

This adjusts the initialization path to ensure that the lookup for
`_Block_destructInstance` is portable to Windows.
@compnerd
Copy link
Member Author

CC: @parkera

@compnerd
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable, I'll trust that you've tested it since we have no CI for Windows.

@compnerd compnerd merged commit c0bb0ce into swiftlang:master Jun 15, 2018
@compnerd compnerd deleted the closure branch June 15, 2018 17:46
@millenomi
Copy link
Contributor

It would be amazing at this point if we could have a CI node hooked up to ci-external for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants