-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[SR-7938] Add URLProtectionSpace.description #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
swift-ci
merged 7 commits into
swiftlang:master
from
cmilr:add-URLProtectionSpace.description
Jun 21, 2018
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
da7e819
Add tests for URLProtectionSpace.description property
cmilr d88331d
Add missing URLProtectionSpace.description property
cmilr 5ea0143
Add tests to TestFoundation/main.swift
cmilr 2925f0a
Update Foundation.xcodeproj/project.pbxproj file
cmilr 2cd4d5f
Update Copyright date, modify prefix assertion to pass when using Darwin
cmilr 017f820
Remove extraneous space in test string to get passing in both Darwin …
cmilr b98ddbb
Add to DarwinCompatibilityTests
cmilr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2014 - 2016 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See http://swift.org/LICENSE.txt for license information | ||
| // See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
|
|
||
| class TestURLProtectionSpace : XCTestCase { | ||
|
|
||
| static var allTests: [(String, (TestURLProtectionSpace) -> () throws -> Void)] { | ||
| return [ | ||
| ("test_description", test_description), | ||
| ] | ||
| } | ||
|
|
||
| func test_description() { | ||
| var space = URLProtectionSpace( | ||
| host: "apple.com", | ||
| port: 80, | ||
| protocol: "http", | ||
| realm: nil, | ||
| authenticationMethod: "basic" | ||
| ) | ||
| XCTAssert(space.description.hasPrefix("<\(type(of: space))")) | ||
| XCTAssert(space.description.hasSuffix(": Host:apple.com, Server:http, Auth-Scheme:NSURLAuthenticationMethodDefault, Realm:(null), Port:80, Proxy:NO, Proxy-Type:(null)")) | ||
|
|
||
| space = URLProtectionSpace( | ||
| host: "apple.com", | ||
| port: 80, | ||
| protocol: "http", | ||
| realm: nil, | ||
| authenticationMethod: "NSURLAuthenticationMethodHTMLForm" | ||
| ) | ||
| XCTAssert(space.description.hasPrefix("<\(type(of: space))")) | ||
| XCTAssert(space.description.hasSuffix(": Host:apple.com, Server:http, Auth-Scheme:NSURLAuthenticationMethodHTMLForm, Realm:(null), Port:80, Proxy:NO, Proxy-Type:(null)")) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new file so that date should just be 2018