[gardening] Remove duplicate code in NSCalendar #1628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaviolima
changed the title
|
Could the remaining code be simplified down to: to cut down on the large |
|
I will do it, once I fix this: Google is not helping much to fix that. :/ |
|
@otaviolima Are you using the Xcode10 beta? Because that is required for current snapshots. |
|
I was, but it started giving me another error then I switch back to Xcode 9 then above error was shown. I'm installing Xcode 10 beta 3 now. |
otaviolima
force-pushed
the
remove-nscalendar-duplicate-code
branch
from
1de9a94 to
5c3a237
Compare
otaviolima
force-pushed
the
remove-nscalendar-duplicate-code
branch
from
5c3a237 to
66eaab1
Compare
|
Done. |
|
@swift-ci please test |
|
It passed: https://ci.swift.org/view/Pull%20Request/job/swift-corelibs-foundation-PR-Linux/1160/console Is the reporting/github hook broken? |
|
@otaviolima Its quite common that the CI->GitHub update hook doesn't always work, I'll kick off another test just to see if it updates |
|
@swift-ci please test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed code seems to be a wrong copy-paste inside each function.