NSFileHandle/NSPipe compatibility #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Objective-C, the fileHandleFor{Reading,Writing} property is mutable even on a
const instance. Change the property to read/write.
Since these are meant to be read/write properties as per Objective-C, this needs to be a stored property. However, it is not possible to have stored properties in an extension. Move the definition into the actual class definition. Default initialize to a closure that will invoke `NSUnimplemented`.
|
@swift-ci please test |
|
This work is needed to actually support SwiftSyntax on Linux |
|
CC: @harlanhaskins |
compnerd
changed the title
parkera
approved these changes
Aug 10, 2018
|
Thanks @parkera! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.