Allow header files to be parsed by C++ parsers #1660
Conversation
|
@swift-ci please test |
CoreFoundation/Base.subproj/CFBase.h
Outdated
| #define CF_RESTRICT restrict | ||
| #endif | ||
| #endif | ||
|
|
There was a problem hiding this comment.
This is a public header so we can't just add the macro here. Perhaps ForSwiftFoundationOnly.h?
There was a problem hiding this comment.
The restrict is used in CFPlatform.c and CFStorage.c, so could move it into CFInternal.h instead?
There was a problem hiding this comment.
I was thinking CFInternal as well, but then it's used in ForSwiftFoundationOnly.h. I'd prefer the internal header if possible.
There was a problem hiding this comment.
So it looks like if we put it in CFInternal.h then it can't be used for the ForSwiftFoundationOnly.h. We could have the macro in CFInternal for ease of maintenance and then have a special-case for the ForSwiftFoundationOnly that duplicates it, but it's not elegant.
There was a problem hiding this comment.
So @parkera I have moved the definitions to be internal only, but can't use it in the ForSwiftFoundation file. I'm not sure which approach you'd like me to take here in terms of conditionally defining the value of restrict -- I've duplicated the line here, but it's introducing duplicate code which I don't like. Any other preferences/suggestions?
rdar://problem/42898878
rdar://problem/42898878
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@parkera any thoughts as to the new approach suggested here? |
|
@swift-ci please test and merge |
By replacing
namspacewithname_spaceand changing therestrictinto__restrict__in C++ mode, the headers can now be parsed by clang++ as well as clang.