Fix DateFormatter behaviour for nil locale and timeZone. #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The locale and timeZone properties of DateFormatter seems to be "null resetteable" in macOS, but the Swift Foundation behaviour differs. Before this patch, setting locale to nil would segfault the program the next time the formatter is used, while timeZone will incorrectly return nil. After this patch a nil locale will simply reset to the current locale and a nil timeZone will reset to the system one. The tests check that the initial defaults are also correctly set.
|
@swift-ci please test |
spevans
pushed a commit
to spevans/swift-corelibs-foundation
that referenced
this pull request
Mar 8, 2019
) The locale and timeZone properties of DateFormatter seems to be "null resetteable" in macOS, but the Swift Foundation behaviour differs. Before this patch, setting locale to nil would segfault the program the next time the formatter is used, while timeZone will incorrectly return nil. After this patch a nil locale will simply reset to the current locale and a nil timeZone will reset to the system one. The tests check that the initial defaults are also correctly set. (cherry picked from commit 1965003)
weissi
added a commit
that referenced
this pull request
Mar 8, 2019
[4.2] Fix DateFormatter behaviour for nil locale and timeZone. (#1681)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locale and timeZone properties of DateFormatter seems to be "null
resetteable" in macOS, but the Swift Foundation behaviour differs.
Before this patch, setting locale to nil would segfault the program the
next time the formatter is used, while timeZone will incorrectly return
nil. After this patch a nil locale will simply reset to the current
locale and a nil timeZone will reset to the system one.
The tests check that the initial defaults are also correctly set.