Skip to content

[Decimal] Make a minor edit to synchronize with overlay #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

xwu
Copy link
Contributor

@xwu xwu commented Sep 2, 2018

This PR applies a minor edit to swift-corelibs-foundation to synchronize with the overlay. No functional change is intended.

Although it ought to be purely cosmetic, the original motivation for the change was that the Swift compiler that day on the master branch refused to accept UInt64(abs(value)). Therefore, since there's a cleaner way to express the operation anyway, I made minor edits mostly for the sake of allowing compilation to proceed. Now, these changes are made here for the sake of synchrony.

No new tests are required.

@xwu
Copy link
Contributor Author

xwu commented Sep 2, 2018

@swift-ci please test

@xwu
Copy link
Contributor Author

xwu commented Sep 2, 2018

@parkera Thanks for merging swiftlang/swift#18486. This is a follow-up to synchronize minor edits here.

@parkera
Copy link
Contributor

parkera commented Sep 14, 2018

Thanks @xwu

@parkera parkera merged commit a481fd9 into swiftlang:master Sep 14, 2018
@xwu xwu deleted the eine-kleine-korrektur branch September 15, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants