Fix broken CoreFoundation standalone build #1685
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure how these got lost but I found them again :)
|
@swift-ci test |
|
cc @spevans @DougGregor as recent mergers. I don't think the bot listens to me 😄also doubt the CI process will find much if it didn't notice this was broken in the first place 🤕 |
|
@swift-ci please test |
|
Thanks @DougGregor! Was my issue not saying "please" to the bot or am I just not authorized to talk to it? I have a few other pending small fixes to the CF build and was just curious if there was a better way to engage. |
|
There is a whitelist of contributors who can trigger CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how these got lost but I found them again :)
Also there's a lot of weird whitespace/indentation in that file but I won't pollute this diff with a fix for that.