Fix unnecessary (and broken) preprocessor exclusion #1686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not 100% sure this is the correct fix, but the __nameStringOK static function gets used even if DEPLOYMENT_RUNTIME_SWIFT is unset, so this just breaks the build (linkage) if this block of code gets excluded. It also just doesn't seem very Swift-specific, to my uneducated eye.
parkera
approved these changes
Sep 11, 2018
|
LGTM |
|
@swift-ci test and merge |
|
Thanks @parkera! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure this is the correct fix, but the
__nameStringOKstatic function gets used even ifDEPLOYMENT_RUNTIME_SWIFTis unset, so this just breaks the build (linkage) if this block of code gets excluded. It also just doesn't seem very Swift-specific, to my uneducated eye.cc @DougGregor or anyone willing to suggest a better fix