Skip to content

Add Support for i686 Targets #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/target.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class ArchType:
shave = 39
armv6 = 40
s390x = 41
i686 = 42
# Do not assume that these are 1:1 mapping. This should follow
# canonical naming conventions for arm, etc. architectures.
# See apple/swift PR #608
Expand Down Expand Up @@ -110,6 +111,8 @@ def to_string(value):
return "thumbeb"
if value == ArchType.x86:
return "i386"
if value == ArchType.i686:
return "i686"
if value == ArchType.x86_64:
return "x86_64"
if value == ArchType.xcore:
Expand Down Expand Up @@ -202,6 +205,8 @@ def from_string(string):
return ArchType.thumbeb
if string == "x86":
return ArchType.x86
if string == "i686":
return ArchType.i686
if string == "x86_64":
return ArchType.x86_64
if string == "xcore":
Expand Down